Repository navigation
Save configured exercises to the routine draft - #86
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
How the form works
The configuration screen uses a small local React Hook Form for the exercise being edited. Clicking Done validates that exercise with the shared contract, appends the parsed result to the parent routine form, and navigates back to the routine editor.
The shared Zod defaults make fields optional on the schema's input side because omitted or
undefinedvalues can be replaced. After parsing, those fields are guaranteed. The routine form therefore uses separatez.inputandz.outputtypes so React Hook Form accurately represents both the editable values and validated submission values.Validation
pnpm lintpnpm typecheck