Repository navigation
Refine routine exercise editing and save routines - #89
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Editing flow
The configuration route accepts an optional validated position search parameter. Without a position, configuration adds a new exercise. With a position, it loads and replaces that exact draft occurrence.
Save flow
React Hook Form owns the draft across the nested creation routes. Clicking Save validates the draft with the shared Zod contracts, maps it into the API request shape, and starts the create mutation. Exercise names remain in the form for display but are removed before the request because the API only needs exercise IDs and configuration values.
After the API accepts the routine, TanStack Query marks the cached routine list as stale. This ensures the routines page can refetch the latest server data. The local draft is then cleared and the user is returned to the routines page. A failed request leaves the draft in place and displays an inline error.
Scheduling remains optional, but the routine name and at least one exercise are required. In a follow-up PR, Save will remain clickable for incomplete drafts and display specific inline validation messages instead of being disabled.
Verification