Repository navigation
Create custom exercises from routine picker - #92
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
State ownership
TanStack Query owns server-derived exercise data such as names and descriptions. React Hook Form stores only routine-specific configuration plus exerciseId and draftExerciseId. This avoids keeping duplicate exercise names synchronized between the query cache and the routine draft.
The routine editor observes the existing exercise cache without fetching. Updating the cache after a rename therefore updates the displayed routine exercise name automatically.
Security
The update service matches both the exercise ID and authenticated owner ID. Built-in exercises and exercises owned by another user cannot be renamed through this endpoint.
Verification