Handle revisions in play-by-play data - #13
Open
Brandon-Michaud wants to merge 1 commit into
Open
Conversation
I noticed that sometimes the play-by-play csv files have revisions when an event was forgotten and it was added at a later time. This means the event has a higher EVENTNUM, but the PCTIMESTRING displays the actual time of the event. This commit changes the starters parser to handle such revisions, whereas it could not in the past. I noticed one issue: When a player is subbed in and out during the same period and time on PCTIMESTRING and the first event was missed and included as a revision. This could be being subbed in before a free throw, the free throw was made, a timeout was called, and being subbed out. This is an incredibly rare event and the only game IDs I found it being an issue are 0029701045 0020500090 0022201040
Author
|
Before these changes, the parser would find a number of starters other than 5, creating issues for the next step of parsing possessions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that sometimes the play-by-play csv files have revisions when an event was forgotten and it was added at a later time. This means the event has a higher EVENTNUM, but the PCTIMESTRING displays the actual time of the event. This commit changes the starters parser to handle such revisions, whereas it could not in the past.
I noticed one issue: When a player is subbed in and out during the same period and time on PCTIMESTRING and the first event was missed and included as a revision. This could be being subbed in before a free throw, the free throw was made, a timeout was called, and being subbed out. This is an incredibly rare event and the only game IDs I found it being an issue are 0029701045
0020500090
0022201040