Integrates OSut/OSlg updates #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brgix
commented
Aug 12, 2025
| docker exec -t test ls | ||
| docker exec -t test bundle update | ||
| docker exec -t test bundle exec rake | ||
| docker kill test |
Member
Author
There was a problem hiding this comment.
Dropping older OpenStudio SDK version test runs ...
brgix
commented
Aug 12, 2025
| docker exec -t test ls | ||
| docker exec -t test bundle update | ||
| docker exec -t test bundle exec rake | ||
| docker kill test |
Member
Author
There was a problem hiding this comment.
... in favour of more recent ones.
brgix
commented
Aug 12, 2025
| open = open.get | ||
|
|
||
| open_roofs = TBD.getRoofs(open) | ||
| open_roofs = TBD.roofs(open) |
Member
Author
There was a problem hiding this comment.
This is the only OSut API change that affects TBD. No change in results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TBD has the following dependencies:
Both gems are in the process of being upgraded, tested, and eventually re-released. TBD is built mainly as an OpenStudio measure, with static copies of both gem .rb files distributed with the TBD measure. So any re-releases of OSut and/or OSlg implies releasing TBD.
For TBD, this will likely be a simple patch re-release: