RDKB-63166: Update device.properties file during runtime#233
Merged
RDKB-63166: Update device.properties file during runtime#233
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds runtime support for updating the device.properties file for OneStack products. It specifically targets the "comcast-business" partner ID and calls a new function from the onestack_init library to apply partner defaults to the device properties file.
Changes:
- Added include for
<onestack_init.h>header to access OneStack initialization functions - Added conditional logic to call
addPartnerDefaultsToDevPropFile()for comcast-business partner ID - Updated Makefile to link against the
-lonestack_initlibrary
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| source/scripts/init/src/apply_system_defaults/apply_system_defaults.c | Added include for onestack_init.h and conditional code block to update device.properties file at runtime for comcast-business partner |
| source/scripts/init/src/apply_system_defaults/Makefile.am | Added -lonestack_init library dependency to linker flags for OneStack builds |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
source/scripts/init/src/apply_system_defaults/apply_system_defaults.c
Outdated
Show resolved
Hide resolved
source/scripts/init/src/apply_system_defaults/apply_system_defaults.c
Outdated
Show resolved
Hide resolved
apattu200
reviewed
Feb 19, 2026
source/scripts/init/src/apply_system_defaults/apply_system_defaults.c
Outdated
Show resolved
Hide resolved
abhishek-kumaracee2
force-pushed
the
feature/RDKB-63166-onestack
branch
from
05de44c to
e124b3d
Compare
Reason for change: for onestack support Test Procedure: NA Risks: Low Priority: Medium Signed-off-by: abhishek_kumaracee2@comcast.com
abhishek-kumaracee2
force-pushed
the
feature/RDKB-63166-onestack
branch
from
e124b3d to
2d00eec
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
apattu200
approved these changes
Feb 26, 2026
apattu200
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: for onestack support
Test Procedure: NA
Risks: Low
Priority: Medium
Signed-off-by: abhishek_kumaracee2@comcast.com