RDKB-63624 Change from business mode check to feature supported check for TSIP#246
Merged
snayak002c merged 1 commit intodevelopfrom Feb 26, 2026
Merged
RDKB-63624 Change from business mode check to feature supported check for TSIP#246snayak002c merged 1 commit intodevelopfrom
snayak002c merged 1 commit intodevelopfrom
Conversation
hpatel006c
approved these changes
Feb 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates OneStack True Static IP (TSIP) enablement logic in the firewall component to rely on “feature supported in current mode” gating rather than device business-mode gating, aligning TSIP behavior with the feature-mode gate mechanism.
Changes:
- Replaced
is_devicemode_business()checks withisFeatureSupportedInCurrentMode(FEATURE_TRUE_STATIC_IP)in TSIP-related NAT/static-IP flows. - Switched OneStack-specific include from
devicemode.htordkb_feature_mode_gate.h. - Updated OneStack link dependencies to use
-lrdkb_feature_mode_gateinstead of-ldevicemode(and removed-lonestack_syscfg/-lonestack_logfrom this Makefile).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| source/firewall/firewall.c | Uses feature-mode gate API to determine TSIP support instead of business-mode device check. |
| source/firewall/Makefile.am | Links OneStack builds against librdkb_feature_mode_gate to support the new gating API. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
snayak002c
pushed a commit
to rdkcentral/provisioning-and-management
that referenced
this pull request
Feb 26, 2026
… for TSIP and OneToOneNAT (#224) US: RDKB-63097: Subtask: RDKB-63624 Handle static ip for Firewall, OneToOneNAT and Static Routing Reason for change: Add changes to change the checks which enable for firewall true static ip and OnetoOneNAT in dml layer from device mode to feature supported mode. Test Procedure: Build with OneStack distro and test Risks: None Is this a Bug or a User Story (US)?: US: RDKB-63097 [XB10] Handle static IPv4 configuration for business Partner ID. Subtask: RDKB-63624 If it is a User Story: • Gerrit topic or list of all dependent PRs across components (including meta-layer changes) been shared?: rdkcentral/utopia#246
snayak002c
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
US: RDKB-63097: Subtask: RDKB-63624 Handle static ip for Firewall, OneToOneNAT and Static Routing
Reason for change: Add changes to change the checks which enable for firewall true static ip from device mode to feature supported mode.
Test Procedure: Build with OneStack distro and test
Risks: None
Is this a Bug or a User Story (US)?: US: RDKB-63097 [XB10] Handle static IPv4 configuration for business Partner ID. Subtask: RDKB-63624
If it is a User Story:
• Gerrit topic or list of all dependent PRs across components (including meta-layer changes) been shared?:
rdkcentral/provisioning-and-management#224