RDKB-62863: WiFi ready page is missing in captive portal#105
RDKB-62863: WiFi ready page is missing in captive portal#105pavankumar464 wants to merge 1 commit intodevelopfrom
Conversation
Reason for change: WiFi ready page is missing in captive portal after a Factory reset in 8.2x Test Procedure: Test for captive portal Risks:low Priority: P1 Signed-off-by: pavankumarreddy_balireddy@comcast.com
There was a problem hiding this comment.
Pull request overview
This PR addresses a bug where the WiFi ready page was not displaying in the captive portal after a factory reset. The fix relocates the setTimeout call that triggers the ready page display from inside the AJAX success callback to immediately after the saveConfig() function initiates the AJAX request.
Changes:
- Moved setTimeout call for goToReady() from AJAX success callback to execute immediately after postConfig() is called for non-WiFi connections
- Timer now starts when configuration save begins rather than after successful completion
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if(connectionType != "WiFi"){ | ||
| setTimeout(function(){ goToReady(); }, 25000); | ||
| } |
There was a problem hiding this comment.
The setTimeout now starts immediately when saveConfig() is called, rather than after AJAX success. This means goToReady() will execute after 25 seconds regardless of whether the configuration was successfully saved. If the AJAX request is retrying (up to 3 retries with 3-second delays each, potentially taking 9+ seconds) or fails after all retries, the ready page will still be shown, potentially before the configuration is actually saved. This could mislead users into thinking their configuration was saved when it may not have been. Consider tracking AJAX completion status and only showing the ready page after successful save, or add a fallback UI state for when configuration save fails.
Reason for change: WiFi ready page is missing in captive portal after a Factory reset in 8.2x
Test Procedure: Test for captive portal
Risks:low
Priority: P1
Signed-off-by: pavankumarreddy_balireddy@comcast.com