feat: improve centralized API integration and error handling#211
Open
askr09 wants to merge 2 commits into
Open
feat: improve centralized API integration and error handling#211askr09 wants to merge 2 commits into
askr09 wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the frontend’s centralized public API helper by improving fetch error handling and making response parsing more resilient, aligning with Issue #90’s goal of a scalable API communication layer.
Changes:
- Improve non-2xx error handling by attempting to extract a structured error message from the response body.
- Add guarded JSON parsing to reduce crashes on malformed responses.
- Add debugging logs to aid diagnosing API failures.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
20
to
+24
| const response = await fetch(url, { ...defaultOptions, ...options }); | ||
|
|
||
| if (!response.ok) { | ||
| throw new Error(`API Error: ${response.status} ${response.statusText}`); | ||
| if (!response.ok) { | ||
| let errorMessage = `API Error: ${response.status}`; | ||
|
|
||
| try { |
Author
There was a problem hiding this comment.
Addressed the review feedback by improving response handling for:
- Empty responses (204/205)
- Non-JSON responses
- Safer content-type based parsing
- Better fallback error messages
Updated in the latest commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improved the centralized API integration layer by enhancing API error handling and response parsing.
Changes Made
Technical Improvements
Issue
Closes #90