Deterministic sorting for materialized packages/file-facts and TUI risk rows - #9
Closed
rdzehtsiar wants to merge 1 commit into
Closed
Deterministic sorting for materialized packages/file-facts and TUI risk rows#9rdzehtsiar wants to merge 1 commit into
rdzehtsiar wants to merge 1 commit into
Conversation
rdzehtsiar
marked this pull request as ready for review
June 10, 2026 00:55
|
Qodana for RustIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Motivation
Description
relative_pathinfinalize_source_dependenciesto make materializedsource_file_packagesdeterministic.file_analysis.relative_pathinmaterialize_file_factssofile_factsrows are written in a stable order.load_risk_rowstoORDER BY score.score DESC, score.relative_path ASCso rows sort by score (descending) then path (ascending) as required.materializes_source_packages_and_file_facts_in_relative_path_order(store reducer tests) andloads_risk_rows_by_score_desc_then_path_asc(TUI tests) to cover deterministic ordering and score tie-breaking.Testing
cargo fmt --checkand it succeeded.cargo testand all unit tests passed (102 passed+ CLI tests).cargo clippy --all-targets --all-features -- -D warningsand it completed without warnings.git diff --checkand a search for conflict markers (rg -n '^(<<<<<<<|=======|>>>>>>>)') and found none.Codex Task