feature/RM-8903-Optimize-iteration-on-ClientTransactionExtensionCollection - #829
Draft
MichaelKetting wants to merge 2 commits into
Draft
Conversation
MichaelKetting
force-pushed
the
feature/RM-8903-Optimize-iteration-on-ClientTransactionExtensionCollection
branch
from
February 8, 2024 08:23
a9d8187 to
3d81351
Compare
MichaelKetting
marked this pull request as draft
February 8, 2024 08:34
…tensionCollection
MichaelKetting
force-pushed
the
feature/RM-8903-Optimize-iteration-on-ClientTransactionExtensionCollection
branch
from
February 8, 2024 08:34
3d81351 to
30b567b
Compare
MichaelKetting
force-pushed
the
develop
branch
from
August 14, 2024 08:28
d221533 to
147fb1d
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://re-motion.atlassian.net/browse/RM-8903
Design notes:
Split ClientTransactionExtensionCollection into ClientTransactionExtensionCollection and CompundClientTransactionExtension, similiar to CompoundClientTransactionListener. The ClientTransactionExtensionCollection then no longer exposes the IClientTransactionExtension interface and thus prevents non-infrastructure code from triggering the events, which would be cosnidered incorrect API usage anyway (see the EditorBrowsableNeverAttribute currently applied to the interface memberes). The collection API is still exposed via the ClientTransaction.Extensions property to allow registering/removing of IClientTransactionExtension implementations. Possibly, a new name (e.g. ClientTransactionExtensionRegistry would be best.