Honor harness ignore during profile root validation#62
Merged
Conversation
…ig migration - Introduced a new checklist file for structure and full transition checks to guide users through migration and auditing processes. - Updated CLI documentation to include new options for managing orphaned outputs during activation. - Enhanced migration documentation to clarify handling of orphaned managed outputs and their preservation during profile changes. - Created a new reporting and communication guide to assist in preparing migration status updates and summaries. - Revised verification documentation to include orphaned managed outputs as a distinct category in the activation plan.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main..harnessIgnore, fixing generated/runtime Harness-like trees that carry their own.harnessProfileRootmarkers.docs/TESTING.md.examples/tree as ignored for root activation so directharnessc activate --yesworks without the dogfood fixture wrapper.1.0.0-alpha.10and add release notes.Root Cause
The validator's
findProfileRootsOutsideAllowedRootswalk used only a fixed directory skip list. It did not use the Harness ignore matcher, so ignored generated directories could still produceharness.profile_root_outside_source_rootsdiagnostics.Validation
pnpm --filter @harnessconfig/core testpnpm --filter @harnessconfig/core checkpnpm buildnode packages/cli/dist/bin.js validatenode packages/cli/dist/bin.js activate --yesnpx harnessc activate --yespnpm run qualityGITHUB_REF_TYPE=tag GITHUB_REF_NAME=v1.0.0-alpha.10 pnpm run release:verifypnpm run release:publish:npm:dry-runRelease Plan
After this PR merges to
main, create and pushv1.0.0-alpha.10on the merge commit. The publish dry-run confirmed all packages publish with npm dist-taglatest.