Fix partner refunds#181
Open
afonic wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the CP refund flow for "partner" reservations — reservations where an affiliate skipped the payment step, leaving payment_id empty and status = 'partner'. Previously, the refund action would unconditionally attempt a payment-gateway refund, which would fail for these reservations. The fix adds an explicit status allowlist check and wraps the payment-gateway call in a payment_id guard.
Changes:
- Added a
refundableStatusesallowlist (confirmed,partner,completed) with a 400 error for other statuses (e.g.pending,expired,refunded). - Payment gateway refund is now only called when
payment_idis non-empty, allowing partner-skipped-payment reservations to be marked refunded without contacting the gateway. - Added new tests covering partner-skipped-payment refund, partner-with-payment refund, and negative cases for
pending,expired, and already-refundedreservations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Http/Controllers/ReservationCpController.php |
Adds status validation and conditionally gates payment-gateway refund behind payment_id check |
tests/Reservation/ReservationCpTest.php |
Adds five new test cases covering both the happy paths and the new status-rejection guard |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.