feat: support classNames and styles by thinkasany · Pull Request #717 · react-component/input-number

thinkasany · 2025-04-29T12:34:04Z

Summary by CodeRabbit

新功能
- InputNumber 组件支持通过 classNames 和 styles 属性对输入框及操作按钮进行语义化定制样式。
测试
- 新增测试用例，验证 InputNumber 组件对自定义 classNames 和 styles 的支持。

vercel · 2025-04-29T12:34:09Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
input-number	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 29, 2025 1:31pm

coderabbitai · 2025-04-29T12:34:12Z

Walkthrough

本次更改为 InputNumber 组件引入了新的 SemanticContext，用于在组件内部通过上下文传递 classNames 和 styles，从而实现对输入框和操作柄等语义子元素的定制化样式支持。InputNumberProps 接口增加了 styles 属性，并调整了 classNames 的类型。InternalInputNumber 和 StepHandler 组件均改为通过 SemanticContext 获取样式和类名。新增了相关的单元测试，用于验证语义化样式和类名的正确性。

Changes

文件/路径	变更摘要
src/InputNumber.tsx	引入 `SemanticContext`，调整 `InputNumberProps`，通过 Provider 传递 `classNames` 和 `styles`，内部组件通过 context 获取样式和类名。
src/SemanticContext.ts	新增，定义并导出 `SemanticContext`，用于语义化样式和类名的上下文传递。
src/StepHandler.tsx	引入并使用 `SemanticContext`，通过 context 获取并应用 `classNames.actions` 和 `styles.actions`，调整类名合并方式。
tests/semantic.test.tsx	新增单元测试，验证 `InputNumber` 支持语义化的 `classNames` 和 `styles`，确保样式和类名正确应用。

Sequence Diagram(s)

sequenceDiagram
    participant App
    participant InputNumber
    participant SemanticContext
    participant InternalInputNumber
    participant StepHandler

    App->>InputNumber: 传递 classNames, styles
    InputNumber->>SemanticContext: Provider(classNames, styles)
    InputNumber->>InternalInputNumber: 渲染
    InternalInputNumber->>SemanticContext: useContext 获取 classNames, styles
    InternalInputNumber->>StepHandler: 渲染
    StepHandler->>SemanticContext: useContext 获取 classNames, styles

Poem

🐰
语义上下文新上线，
样式传递更自然。
输入数字添新衣，
操作柄也换新颜。
测试加持保安全，
代码小兔乐开怀！

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

tests/semantic.test.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-react".

(The package "eslint-plugin-react" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-react@latest --save-dev

The plugin "eslint-plugin-react" was referenced from the config file in ".eslintrc.js » /node_modules/.pnpm/@umijs+fabric@4.0.1_jest@29.7.0_@types+node@22.15.3_ts-node@10.9.2_@types+node@22.15.3_typescript@5.8.3___postcss@8.5.3/node_modules/@umijs/fabric/dist/eslint.js".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fff7f7e and ce57221.

📒 Files selected for processing (1)

tests/semantic.test.tsx (1 hunks)

✅ Files skipped from review due to trivial changes (1)

tests/semantic.test.tsx

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

zombieJ · 2025-04-29T13:13:06Z

src/InputNumber.tsx

  return decimal.isInvalidate() ? null : decimal;
 };

+type SemanticName = 'handle' | 'input';


indicator or actions?

zombieJ · 2025-04-29T13:26:47Z

src/InputNumber.tsx

      ...inputProps
    } = props;

+    const { classNames, styles } = React.useContext(SemanticContext) || {};


这边不对，InputNumber 已经是顶层了，没有需要从 context 拿的东西

codecov · 2025-04-29T13:35:46Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.02%. Comparing base (4470642) to head (ce57221).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #717      +/-   ##
==========================================
+ Coverage   95.95%   96.02%   +0.06%     
==========================================
  Files           6        7       +1     
  Lines         297      302       +5     
  Branches       78       79       +1     
==========================================
+ Hits          285      290       +5     
  Misses         12       12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

thinkasany added 2 commits April 29, 2025 20:33

feat: support classNames and styles

e4d1cf4

rm

b9017d5

vercel bot deployed to Preview April 29, 2025 12:35 View deployment

zombieJ reviewed Apr 29, 2025

View reviewed changes

handle to actions

fff7f7e

vercel bot deployed to Preview April 29, 2025 13:17 View deployment

zombieJ reviewed Apr 29, 2025

View reviewed changes

fix ci

ce57221

vercel bot deployed to Preview April 29, 2025 13:31 View deployment

zombieJ merged commit 38b4908 into react-component:master Apr 29, 2025
11 checks passed

yoyo837 mentioned this pull request Apr 29, 2025

feat(InputNumber): support classNames and styles for component and ConfigProvider ant-design/ant-design#53698

Merged

2 tasks

coderabbitai bot mentioned this pull request May 16, 2025

fix: actions semantic #718

Merged

coderabbitai bot mentioned this pull request Sep 1, 2025

fix: Remove mobile device detection #719

Merged

coderabbitai bot mentioned this pull request Oct 17, 2025

feat(spinner): support spinner type #721

Merged

coderabbitai bot mentioned this pull request Nov 10, 2025

refactor: InputNumber semantic refactor #726

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: support classNames and styles#717

feat: support classNames and styles#717
zombieJ merged 4 commits intoreact-component:masterfrom
thinkasany:cp

thinkasany commented Apr 29, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Apr 29, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Apr 29, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

zombieJ Apr 29, 2025

Uh oh!

zombieJ Apr 29, 2025

Uh oh!

codecov bot commented Apr 29, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

thinkasany commented Apr 29, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

vercel bot commented Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

zombieJ Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

zombieJ Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

thinkasany commented Apr 29, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Apr 29, 2025 •

edited

Loading

coderabbitai bot commented Apr 29, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Apr 29, 2025 •

edited

Loading