Fix iOS clipboard listener events#296
Open
solaoi wants to merge 1 commit intoreact-native-clipboard:masterfrom
Open
Fix iOS clipboard listener events#296solaoi wants to merge 1 commit intoreact-native-clipboard:masterfrom
solaoi wants to merge 1 commit intoreact-native-clipboard:masterfrom
Conversation
RNCClipboard overrode addListener/removeListeners with no-op stubs, which prevents RCTEventEmitter from tracking listener count and starting observation. Delegate both methods to the superclass so Clipboard.addListener works on iOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
I noticed that
Clipboard.addListenerdoes not fire on iOS.The root cause is that RNCClipboard exports
addListener/removeListenersas no-op methods, which preventsRCTEventEmitterfrom tracking the listener count and callingstartObserving.As a result, clipboard change events are not delivered to JavaScript even though
UIPasteboardChangedNotificationis observed natively.This PR fixes the issue by delegating both exported methods to the superclass (
RCTEventEmitter) implementation so that listener tracking and observation lifecycle work as intended.Related issue: #231
Test Plan