Skip to content

Add flexbox error logging for native #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
necolas merged 1 commit into from
Jul 17, 2025
Merged

Add flexbox error logging for native #341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions packages/react-strict-dom/src/native/stylex/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,6 +637,37 @@ export function props(
if (boxSizingValue === 'content-box' && !version.experimental) {
nextStyle = fixContentBox(nextStyle);
}

// Print an error message if flex properties are used without
// "display:flex" being set. React Native is always using "flex"
// layout but web uses "flow" layout by default, which can lead
// to layout divergence if building for native first.
if (__DEV__) {
if (
nextStyle.display == null ||
(nextStyle.display !== 'flex' && nextStyle.display !== 'none')
) {
if (
nextStyle.alignContent != null ||
nextStyle.alignItems != null ||
nextStyle.alignSelf != null ||
nextStyle.columnGap != null ||
nextStyle.flex != null ||
nextStyle.flexBasis != null ||
nextStyle.flexDirection != null ||
nextStyle.flexGrow != null ||
nextStyle.flexShrink != null ||
nextStyle.flexWrap != null ||
nextStyle.gap != null ||
nextStyle.justifyContent != null ||
nextStyle.placeContent != null ||
nextStyle.rowGap != null
) {
errorMsg('"display:flex" is required to use flexbox properties');
}
}
}

nativeProps.style = nextStyle;

return nativeProps;
Expand Down
26 changes: 26 additions & 0 deletions packages/react-strict-dom/tests/css-test.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,32 @@ describe('properties: general', () => {
expect(css.props.call(mockOptions, styles.rtl)).toMatchSnapshot('rtl');
});

test('display', () => {
const styles = css.create({
flex: {
display: 'flex'
},
align: {
alignItems: 'center'
},
row: {
flexDirection: 'row'
}
});
css.props.call(mockOptions, [styles.flex, styles.align]);
expect(console.error).not.toHaveBeenCalledWith(
expect.stringContaining(
'"display:flex" is required to use flexbox properties'
)
);
css.props.call(mockOptions, [styles.align, styles.row]);
expect(console.error).toHaveBeenCalledWith(
expect.stringContaining(
'"display:flex" is required to use flexbox properties'
)
);
});

test('filter', () => {
const { underTest } = css.create({
underTest: {
Expand Down