Skip to content

Set the default viewportScale to 1 even if no provider is used #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
necolas merged 1 commit into from
Jul 25, 2025
Merged

Set the default viewportScale to 1 even if no provider is used #349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-strict-dom/src/native/stylex/CSSLengthUnitValue.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export class CSSLengthUnitValue {
fontScale = 1,
inheritedFontSize,
viewportHeight,
viewportScale,
viewportScale = 1,
viewportWidth
} = options;
const unit = this.unit;
Expand Down
2 changes: 1 addition & 1 deletion packages/react-strict-dom/src/native/stylex/CSSTransformValue.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export class CSSTransformValue {
}

resolveTransformValue(
viewportScale: number
viewportScale?: number = 1
): $ReadOnlyArray<ReactNativeTransform> {
if (viewportScale === 1) {
return this.value;
Expand Down
2 changes: 1 addition & 1 deletion packages/react-strict-dom/src/native/stylex/__tests__/parseTransform-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import { parseTransform as parseTransformImpl } from '../parseTransform';

function parseTransform(transform) {
return parseTransformImpl(transform).resolveTransformValue(1);
return parseTransformImpl(transform).resolveTransformValue();
}

describe('parseTransform', () => {
Expand Down
4 changes: 2 additions & 2 deletions packages/react-strict-dom/src/native/stylex/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ type ResolveStyleOptions = $ReadOnly<{
hover?: ?boolean,
inheritedFontSize: ?number,
viewportHeight: number,
viewportScale: number,
viewportScale: number | void,
viewportWidth: number,
writingDirection?: ?'ltr' | 'rtl'
}>;
Expand Down Expand Up @@ -298,7 +298,7 @@ function resolveStyle(
hover,
inheritedFontSize,
viewportHeight,
viewportScale,
viewportScale = 1,
viewportWidth
} = options;
const colorScheme = options.colorScheme || 'light';
Expand Down
6 changes: 2 additions & 4 deletions packages/react-strict-dom/tests/css-test.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@ import { css } from 'react-strict-dom';
const mockOptions = {
hover: false,
viewportHeight: 600,
viewportWidth: 320,
viewportScale: 1
viewportWidth: 320
};

/**
Expand Down Expand Up @@ -1732,8 +1731,7 @@ expect.extend({
const theProps = css.props.call(
{
viewportHeight: height,
viewportWidth: width,
viewportScale: 1
viewportWidth: width
},
underTest
);
Expand Down