Remove 'content-box' and most logical CSS polyfills from native#360
Closed
necolas wants to merge 2 commits into
Closed
Remove 'content-box' and most logical CSS polyfills from native#360necolas wants to merge 2 commits into
necolas wants to merge 2 commits into
Conversation
workflow: benchmarks/sizeComparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.
|
workflow: benchmarks/perf (native)Comparison of performance test results, measured in operations per second. Larger is better.
|
necolas
force-pushed
the
native/remove-css-polyfills
branch
from
b1da050 to
0559b5b
Compare
React Native has built-in support for content-box now
Replace the polyfills with the built-in support for `marginInline`, etc.
necolas
force-pushed
the
native/remove-css-polyfills
branch
from
0559b5b to
9f87934
Compare
Contributor
Author
|
Closing because the removal of the logical styles polyfill causes a regression to some inline margins in FBVR. There was almost no e2e perf benefit to this change so it can wait until we understand the cause. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rely on React Native's recent built-in support for these capabilities
e2e benchmark comparison