feat: Use memcpy instead of std::copy

[bnbajwa]

memcpy can be faster. std::copy results in call to memmove if compiler can't be certain that the memory regions do not overlap.

SDB-10043

[gemini-code-assist]

Summary of Changes

Hello @bnbajwa, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a performance optimization by switching from std::copy to std::memcpy for copying raw character data within the OStreamBase utility. This change is aimed at leveraging the potentially faster, byte-level memory transfer capabilities of memcpy for Plain Old Data (POD) types, thereby enhancing the efficiency of data handling operations.

Highlights

• Performance Optimization: Replaced std::copy with std::memcpy in the put_data method of OStreamBase to potentially improve performance for raw data copying.
• Header Inclusion: Added the <cstring> header to OStreamBase.hpp to provide the declaration for std::memcpy.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to improve performance by replacing std::copy with std::memcpy in OStreamBase::put_data. While memcpy can be faster, it introduces the risk of undefined behavior if the source and destination memory regions overlap. My feedback suggests using std::memmove instead, which is safe for overlapping regions and generally has comparable performance. This ensures correctness against potential edge cases without sacrificing the intended performance gain.