chore: Using Mono clock for Reactor time thresholds

[bnbajwa]

SDB-10154

[gemini-code-assist]

Summary of Changes

Hello @bnbajwa, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the reliability and accuracy of the ReactorHighPriorityHook unit test. The changes involve refining the timing parameters and the logic for simulating an expensive operation, ensuring the test accurately reflects its intended scenario and improves its overall stability.

Highlights

• Test Timing Adjustment: The timing parameters within the ReactorHighPriorityHook unit test have been adjusted to more accurately reflect the simulated expensive operation.
• Simulated Duration Alignment: The simulated duration of the expensive handler in the test now correctly matches the descriptive comments, changing from 500ms to 250ms.
• Improved Yield Mechanism: The internal yield mechanism within the test's on_data_received handler has been refined to use WallClock::now() for next_stop calculation, enhancing timing accuracy and robustness.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses an issue in the ReactorHighPriorityHook test case by correcting the logic in a busy-wait loop to ensure it waits for the intended duration, which improves the test's reliability. The test's total run time is also reduced. The change is correct, but I've added a suggestion to use a monotonic clock to further improve test robustness against system time changes.