Make export CSS collection robust to pseudo-element selectors - #170
Merged
Conversation
querySelector threw on reset rules like `*, ::before, ::after`, aborting export.
Member
|
@aindlq Thanks for the fix! I checked it and it looks like everything OK except for one (unlikely) case if parenthesis is nested inside an attribute selector: <div data-x(>...</div>[data-x\\(] { color: red; }I handled the case in the additional commit to the PR branch; I'll push and merge the changes soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
querySelector threw on reset rules like
*, ::before, ::after, aborting export.Related to researchspace/researchspace#448