fix(mdxish): jsx braces not evaluating #1256
Conversation
| // These are not exhaustive, but are a good starting point | ||
| // We probably want to just use a library that'll load most of the common operations for us | ||
| export const DEFAULT_JSX_CONTEXT: JSXContext = { | ||
| uppercase: (value: string) => value.toUpperCase(), |
There was a problem hiding this comment.
Struggling to understand why we're constructing a special context with these operations? If I understand correctly ES language features are already available when we eval the expressions. And I don't believe these functions are available in strict MDX so why/how would a user even know they exist?
Instead of Hello {uppercase("world")} I would instead write Hello {"world".toUpperCase()}
and instead of {add(1, 2)} I would write {1 + 2}
and so on...
Is there a requirement I'm missing here?
There was a problem hiding this comment.
No you are right, apologies, I've found that the issue was with another code that was skipping evaluation if no function context / parameter names are provided. We don't need to define the default contexts for evaluating, so that code check is actually not needed.
Added tests for the string functions you suggested in here
eaglethrost
changed the title
There was a problem hiding this comment.
Using mix instead of mdxish since mix returns a string already (mix is basically stringified mdxish)
| const contextKeys = Object.keys(context); | ||
| const contextValues = Object.values(context); | ||
|
|
||
| // If no context provided, leave expression as-is |
There was a problem hiding this comment.
The problematic check that is now removed
There was a problem hiding this comment.
Moving some things around for cleanliness
2 participants
🧰 Changes
🧬 QA & Testing