fix: prevent nested links when Anchor label looks like a URL #1283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GFM's autolink feature converts URL-like text (e.g., "https://example.com") into link nodes, which creates invalid nested links when the text is inside an <Anchor> component with extra attributes like target="_blank". Changes: - Unwrap nested link nodes in readme-components.ts during MDAST transformation - Unwrap nested <a> elements in Anchor.tsx during React rendering - Add link compiler tests for the nested link edge case - Add Anchor component tests for unwrapping behavior Fixes the bug where links with URL-like labels and "Open in new tab" setting would display as nested links after page reload.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
GFM's autolink feature converts URL-like text (e.g., "https://example.com") into link nodes, which creates invalid nested links when the text is inside an component with extra attributes like target="_blank".
Changes:
Fixes the bug where links with URL-like labels and "Open in new tab" setting would display as nested links after page reload.
Related: readmeio/readme#16851
🧬 QA & Testing