Depend on SDK Nuget packages - #7
Merged
Merged
Conversation
Game assemblies are already loaded in the game process at runtime, so copying them into a build output is wasted space and risks shipping a reference assembly into the game, where a body-less assembly would fail confusingly under Mono. Private="false" on every reference whose HintPath points at a Game folder. Verified against the mod template: 15 game assemblies were being copied into ExampleMod/bin, now zero.
Replaces the <Reference> items pointing at Dependencies/Game with a single PackageReference to reference-only assemblies, and deletes the folder: 54 game DLLs, 91 MB, that no project reads any more. The refs are API surface with no method bodies, used at compile time only. The real assemblies are already loaded in the game process, so nothing changes at runtime and nothing is shipped with a mod.
The UseSdkProjectReferences=true branch used hardcoded ..\..\ paths that assumed the mods lived inside wukong-csharp-mod as submodules. They now go through $(WukongSdkRoot) and $(CoreSdkRoot), defaulted to a side-by-side checkout and overridable by an uberrepo. Both modes verified: package references by default, SDK sources when UseSdkProjectReferences=true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.