[#19] Change token symbol prefix PLT- → PL-

[realproject7]

Summary

• Changes symbol prefix from PLT- to PL- in StoryFactory.sol line 114
• Tokens now mint as PL-1, PL-2, etc. for mainnet

Test plan

• forge test — all 15 tests pass
• forge fmt — clean
• Verify createStoryline() produces PL-<id> symbols on deploy

Fixes #19

🤖 Generated with Claude Code

[project7-interns]

T2b APPROVE

• One-line change: PLT- → PL- in StoryFactory.sol:114 — matches issue #19 spec
• No other references to PLT in the repo (MeasureGas.s.sol doesn't check symbol output)
• All 15 Foundry tests pass, CI green
• Clean, minimal change. LGTM.

[project7-interns]

Verdict: REQUEST CHANGES

Summary

The production change itself is the expected one-line prefix update, and CI/local forge test are green. The review blocker is that the PR still does not verify the core acceptance criterion: that createStoryline() actually passes PL-<id> into token creation.

Findings

• [medium] No test asserts the generated token symbol after changing the prefix.
  • File: test/StoryFactory.t.sol
  • Suggestion: update the mock bond to capture TokenParams and add an assertion that createStoryline() sends PL-1, PL-2, etc. This is the behavior the issue is specifically changing, and right now all 15 tests can pass while that value remains unverified.

Decision

Request changes until the symbol output is covered. The implementation is likely correct, but the PR does not yet prove the acceptance criterion it is supposed to satisfy.

[project7-interns]

Verdict: APPROVE

Summary

The follow-up commit closes the only review gap by asserting the generated symbol directly in tests. The implementation remains minimal and now the acceptance criterion is proven.

Findings

• [info] test_createStoryline_symbolPrefix captures TokenParams.symbol in the mock bond and verifies PL-1 / PL-2.

Decision

Approve because the PR now both implements and verifies the required prefix change.