[#25] Forward MCV2_Bond creation fee in createStoryline

[realproject7]

Summary

• Make createStoryline payable and forward msg.value to BOND.createToken{value: msg.value}()
• Fixes MCV2_Bond__InvalidCreationFee revert on Base mainnet (0.0007 ETH fee)
• Redeployed StoryFactory to Base mainnet: 0xc278F4099298118efA8dF30DF0F4876632571948
• Verified on Sourcify (exact_match)

Post-deploy verification

• New contract deployed and verified on Sourcify
• Broadcast artifacts committed

Test plan

• forge test — all 26 tests pass
• forge fmt clean
• Redeployed to Base mainnet
• Sourcify verified
• createStoryline with 0.0007 ETH value succeeds on mainnet

Fixes #25

🤖 Generated with Claude Code

[project7-interns]

T2b APPROVE

Two-line fix, clean and correct:

1. createStoryline marked payable ✓
2. BOND.createToken{value: msg.value}(tp, bp) forwards the creation fee ✓

• Fixes MCV2_Bond__InvalidCreationFee revert on mainnet (0.0007 ETH fee)
• New deployment 0xc278F4099298118efA8dF30DF0F4876632571948 — broadcast artifacts match, constructor args correct
• CI green, 26 tests pass

LGTM.

[project7-interns]

Verdict: REQUEST CHANGES

Summary

The production fix is the expected minimal change, and the redeploy artifact is internally consistent. The blocker is that the test suite still does not prove the bug fix: nothing asserts that msg.value actually reaches BOND.createToken.

Findings

• [medium] No regression test verifies that createStoryline() forwards the creation fee to IMCV2_Bond.createToken.
  • File: test/StoryFactory.t.sol
  • Suggestion: capture msg.value in the mock bond and add a test that calls createStoryline{value: ...}() and asserts the mock received that exact value. Right now all 26 tests can pass even if the payable forwarding path is broken, which is the specific mainnet bug this PR is fixing.

Decision

Request changes until the fee-forwarding behavior is covered by a deterministic test. For a redeploy driven by a production bug, the regression needs to be explicit.

[project7-interns]

Verdict: APPROVE

Summary

The follow-up commit closes the only review gap by explicitly asserting that createStoryline() forwards msg.value into IMCV2_Bond.createToken. The production fix remains minimal, and the redeploy record is consistent.

Findings

• [info] test/StoryFactory.t.sol now captures msg.value in the mock bond and verifies both 0.0007 ETH forwarding and the zero-fee case.

Decision

Approve because the mainnet creation-fee bug is now both fixed and covered by deterministic regression tests.