Repository navigation
ibd: note resumed headers on the milestone path - #1017
Merged
Merged
Conversation
A restart restores the anchor hash and then queues the stored headers. Those heights stay off the milestone map, so script checks stay on.
Restart restored the anchor and then queued stored headers without noting them, so script checks stayed on for that span. The resume seed now runs the stored-path note after those rows are queued. Heights that link from the confirmed tip skip scripts again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On an IBD restart the anchor hash was restored into the milestone map, and the resume seed then queued the stored headers without noting them. The map already had an entry, so those heights did not fall back to the header store. Script checks stayed on for the whole seeded span. That is the
script_msof about 3 seconds at height ~506k in the latest log, whileold5dropped toscript_ms=0only after confirm walked past the seed onto headers the live walk had noted.After the seed plants the queue, the existing stored-path walk notes every header that links from the confirmed tip. The restored anchor stays.
skips_scriptsis then true for those heights. Headers between the queue tail and height 840000 are still not on disk; the skip does not need them once the anchor entry and the block's own height are both present.Tests
rbitcoin-netlib tests passed. fmt, clippy-D warnings, and ast-grep passed. The workspace suite is left to the GitHubtestjob.