Repository navigation
test: fold getnetworkhashps help onto the genesis RPC journey - #1024
Merged
Merged
Conversation
rpc_regtest_from_genesis asks help for getnetworkhashps and checks the text names chainwork. The small unit that only called method_help is deleted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rpc_regtest_from_genesisnow callshelp getnetworkhashpsand checks the text names chainwork and does not sayDummy 2-work. The unit that only calledmethod_helpis deleted. No new#[test].Local fmt, clippy
-D warnings, deny, and ast-grep passed. Workspace tests passed exceptend_of_ibd_sh_interrupt, which also failed on a cleanorigin/mastercheckout of this worktree. That journey is not a destination here../scripts/ci-os-smoke.shpassed.Test plan
cargo test -p rbitcoin-rpc --lib rpc_regtest_from_genesisqc,test,windows,macos,coverage