Repository navigation
test: fold long min-chain-work hex reject onto operator_conf_and_argv - #1025
Merged
Merged
Conversation
operator_conf_and_argv already accepts --min-chain-work=0x65. It now refuses a 65-digit hex spec through apply_kv, which is the outcome minimum_chain_work_hex_and_floor asserted. The 0x65 byte, the non-hex refusal, and meets_minimum_chain_work stay covered by that journey, the operator smoke, and the testnet3 milestone journey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
operator_conf_and_argvrefuses a 65-digit--min-chain-workhex spec throughapply_kv. The error names the 64-digit limit.minimum_chain_work_hex_and_floor. The0x65byte stays on that journey. A non-hex spec still exits 1 from the operator smoke.meets_minimum_chain_workstays on the testnet3 milestone journey andrelay_requires_min_chain_work_even_when_following.Test plan
cargo test -p rbitcoin-node --lib operator_conf_and_argv-D warnings, deny, ast-grep,ci-os-smoke.shoperator_conf_and_argvfail; the operator was restored before commitcargo testfailed only onend_of_ibd_sh_interrupt(Electrum opened before script A history was complete), which this diff does not touch