Skip to content

test: fold ten conf setters onto operator_conf_and_argv - #1026

Closed
rearden-grok[bot] wants to merge 1 commit into
masterfrom
test/conf-journey-folds
Closed

rearden-grok[bot] wants to merge 1 commit into
masterfrom
test/conf-journey-folds

Conversation

@rearden-grok

@rearden-grok rearden-grok Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • operator_conf_and_argv now covers ten conf setters that were separate units: the SV2 authority secret file, Debug redaction, key-utils base58check, max_sh_creates and the Esplora template default, the cwd-relative datadir, inbound env absorption, max_inbound versus Core maxconnections, a file blocking store/, the RPC cookie check, and DNS connect hostnames.
  • Deletes those ten units. No production behavior change.

Test plan

  • cargo test -p rbitcoin-node --lib operator_conf_and_argv
  • fmt, clippy -D warnings, deny, ast-grep, workspace tests, ci-os-smoke.sh
  • Inverting each operator made operator_conf_and_argv fail; each operator was restored before commit

The journey now checks the authority-secret file, Debug redaction,
key-utils base58check, the scripthash create cap, the Esplora template
default, the cwd-relative datadir, inbound env absorption, max_inbound
versus maxconnections, a file blocking the store directory, the RPC
cookie check, and DNS connect hostnames. Those ten units are deleted.
@rearden-grok

rearden-grok Bot commented Oct 16, 2026

Copy link
Copy Markdown
Contributor Author

Rejected. The ten units were pasted into operator_conf_and_argv as their own NodeConfig, temp dir, file, env, and cookie setups. They do not use the argv and conf assembly that journey already builds, so the move does not share setup and does not save work. Leaving the units in place.

@rearden-grok rearden-grok Bot closed this Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants