Repository navigation
test: fold ten conf setters onto operator_conf_and_argv - #1026
Closed
rearden-grok[bot] wants to merge 1 commit into
Closed
rearden-grok[bot] wants to merge 1 commit into
rearden-grok[bot] wants to merge 1 commit into
Conversation
The journey now checks the authority-secret file, Debug redaction, key-utils base58check, the scripthash create cap, the Esplora template default, the cwd-relative datadir, inbound env absorption, max_inbound versus maxconnections, a file blocking the store directory, the RPC cookie check, and DNS connect hostnames. Those ten units are deleted.
Contributor
Author
|
Rejected. The ten units were pasted into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
operator_conf_and_argvnow covers ten conf setters that were separate units: the SV2 authority secret file, Debug redaction, key-utils base58check,max_sh_createsand the Esplora template default, the cwd-relative datadir, inbound env absorption,max_inboundversus Coremaxconnections, a file blockingstore/, the RPC cookie check, and DNSconnecthostnames.Test plan
cargo test -p rbitcoin-node --lib operator_conf_and_argv-D warnings, deny, ast-grep, workspace tests,ci-os-smoke.shoperator_conf_and_argvfail; each operator was restored before commit