Repository navigation
ibd: start a fresh stall window on the next getdata - #1032
Merged
Merged
Conversation
Idle time between batches was still on the clock, so the first ask after a confirm pause looked like a 30s stall. The window now opens when the first getdata of an empty window is written, and it disarms when the peer owes nothing. A later getdata in that same window does not move the deadline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An IBD peer's 30s stall clock now covers one open getdata window.
Test
cargo test -p rbitcoin-net --lib(disconnect stall pins, the assign window pins, and the rest of the lib suite),cargo clippy -p rbitcoin-net --all-targets -- -D warnings,cargo fmt --all,./scripts/ast-grep.sh.