Repository navigation
test: restore conf units pasted into operator_conf_and_argv - #1033
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #1022 and most of #1023 moved conf checks into
operator_conf_and_argvwithout sharing that journey's setup or moving them off private accessors.electrum_max_subs_cli_conf_and_bounds,max_sh_creates_and_esplora_block_template_cli_hyphens,conf_error_names_the_file_and_line,check_blocks_apply_kv_zero_is_all,prefillcompact_cli_conf_default_on) and the test: fold conf apply_kv setters onto operator_conf_and_argv #1023NodeConfig::default()/apply_kvblocks (tor_control_password_rejects_a_line_break,apply_kv_is_the_conf_setter_and_unknown_is_not_error,rpc_socket_moves_the_socket_out_of_the_datadir,blocks_dir_is_not_an_operator_key,duplicate_listen_is_init_error). Restoringapply_kvalso puts back cases the paste dropped:network=regtest, unknowncheckblocks/prefillcompact, and the max-sh / esplora flag matrix.rpc_work_queuedefault,0, and4now go throughready_configargv, which is the surface this journey already uses. The six mempool and sigop deletions from test: fold conf fields and mempool rejects onto existing journeys #1022 stay deleted.mempool_accept_lifeandsigop_adjusted_size_budget_and_reopenalready asserted those errors and sigop counts, and test: fold conf fields and mempool rejects onto existing journeys #1022 did not paste those bodies into the journeys.--check-blocksand--prefill-compactargv asserts that were already on the journey stay there.Test-only. No changelog.
Test plan
cargo fmt -p rbitcoin-nodecargo clippy -p rbitcoin-node --lib --tests -- -D warningsrbitcoin-nodelib tests for the restored names andcli::tests(16 passed)qc,test,windows,macos,coverage