Repository navigation
test: restore decode_rpc_subset and fold network identity - #1039
Merged
Merged
Conversation
decode_rpc_subset stays its own test until node_run_p2p_short observes those bytes. rpc_regtest_from_genesis already opens the hub whose getmempoolinfo and getnetworkinfo show the weight/4 cap and the RPC identity fields, so that unit moves onto that client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
decode_rpc_subsetis a named witness (TESTING.md) and stays its own test untilnode_run_p2p_shortobserves those bytes. #1038 had pasted it ontorpc_regtest_from_genesis. This restores the unit.In its place,
rpc_honesty_mempool_budget_and_network_identityruns on the hub that journey already opens:getmempoolinfo.maxmempoolis75_000_000, the existing300_000_000weight budget divided by 4, and not the weight budget itself.getnetworkinforeports version190000, protocol version70016, the hub subversion, and the local service flags.Test-only. No changelog.