Repository navigation
Pin consensus edges against Bitcoin Core - #1054
Merged
Merged
Conversation
The expected compacts are literals (mainnet 0x1d00d86a, quarter floor, 4x ceiling, pow-limit cap), not a second call to the retarget function.
…edges Taproot hashtype 0x00 and an OP_0 P2SH redeem now run under the real exception hashes. SIGHASH_SINGLE past the last output, the P2PKH find-and-delete collision, witness-v0 NULLDUMMY with the flag off, and unknown tapleaf stack limits are pinned without changing the interpreter.
Empty scriptSig on a real P2PKH output connects only when the header path holds this block and the anchor. One height above, and a different hash at the anchor height, still fail the script.
…IP68 coinbase skip The last 38-byte aa21a9ed output is the commitment. A coinbase witness without one is missing. Nonce lengths 31 and 33 fail. Empty P2WSH and a v1 program cost 0. Coinbase scriptSig length 2 accepts and length 1 rejects. A version-2 coinbase with a relative lock that fails on a normal input still connects.
A valid regtest block payload decodes as a block. One extra byte is NetworkMessage::Unknown. The changelog fragment covers the consensus pins on this branch.
rearden-grok Bot
added a commit
that referenced
this pull request
Oct 17, 2026
The rebase onto the witness, sigop, and BIP68 coinbase pins left store-backed tests calling consensus paths that now live on query. The exception-hash pin stays in consensus because the job verifier is crate-private. Connect results match ConfirmError::Rules.
rearden-grok Bot
added a commit
that referenced
this pull request
Oct 17, 2026
The rebase onto the witness, sigop, and BIP68 coinbase pins left store-backed tests calling consensus paths that now live on query. The exception-hash pin stays in consensus because the job verifier is crate-private. Connect results match ConfirmError::Rules.
rearden-grok Bot
added a commit
that referenced
this pull request
Oct 17, 2026
The rebase onto the witness, sigop, and BIP68 coinbase pins left store-backed tests calling consensus paths that now live on query. The exception-hash pin stays in consensus because the job verifier is crate-private. Connect results match ConfirmError::Rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests only. No production change. These pins describe behavior that is already shipped.
0x1d00d86a, plus the quarter-floor, 4× ceiling, and pow-limit cap.SIGHASH_SINGLEpast the last output is uint256 one. Witness v0 rejects a non-empty CHECKMULTISIG dummy with NULLDUMMY off; base script accepts it. An unknown taproot leaf succeeds past the witness stack limits.bad-witness-nonce-size. Empty P2WSH and a v1 program cost 0. Coinbase scriptSig length 2 accepts and length 1 rejects. BIP68 does not apply to the coinbase.NetworkMessage::Unknown.Test plan
cargo fmt --all --check,cargo clippy --workspace --all-targets -- -D warnings,cargo deny check, and./scripts/ast-grep.shfinished locally before the workspace suite was stoppedqc,test,windows,macos, andcoverage. The local workspace test andci-os-smoke.shwere not finished; the VM was too busy