Repository navigation
Hermes follow-ups: one lock for acks, a bounded version probe, the plugin's tool names - #147
Merged
Merged
Conversation
…ugin's tool names - The bridge finds a session and checks an acknowledgement under one lock, so a failed re-register can't remove the session in between (that panicked the task, and the plugin waited out its 125 s timeout). - `hermes --version` gets 5 seconds; a Hermes that hangs on it no longer hangs setup, init and join. - Bridge errors name the plugin's tools (reason_network_list_agents, ...) instead of the MCP server's. - Hermes comes last in setup's agent list. Signed-off-by: Lars Talian <113114512+larstalian@users.noreply.github.com>
This was referenced Oct 25, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow-ups from the review of #119. Nothing changes for agents other than Hermes.
sessions[&key]to check an acknowledgement. A failed re-register for the same key in between removed the entry, the task panicked, and the plugin waited out its 125 s timeout. Finding the session and checking the ack now happen under one lock.hermes --versionis bounded. Setup runs it to find Hermes's source when there's no installer checkout. It now waits at most 5 seconds and reads the output on its own thread, so a Hermes that hangs, or leaves a child holding its output, no longer hangssetup,initandjoin.list_teamandsend_message; the bridge now saysreason_network_list_agents,reason_network_send_message,reason_network_check_inboxandreason_network_ask_userinstead (whole words only). The MCP server and CLI are unchanged.Tests:
bridgegetserrors_name_the_plugins_toolsandacks_only_for_a_registered_session_and_its_own_mail;setup::hermesgetsa_hermes_that_hangs_on_version_does_not_hang_setup(Unix).