Repository navigation
feat: add an opt-in native Windows desktop directory - #161
Draft
qinghuidaqzp wants to merge 4 commits into
Draft
qinghuidaqzp wants to merge 4 commits into
qinghuidaqzp wants to merge 4 commits into
Conversation
Member
|
Thanks for this, a desktop directory on Windows is a nice idea, and the PR is clearly put together with care. Before we review it in depth, one thing to flag: it adds |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows has daemon and CLI support, but its users cannot browse the live team directory in a desktop window. This adds an opt-in native Windows directory using the project's existing
windows-sysdependency.No new crates:
Cargo.lockis byte-for-byte identical to upstreammain@fea09c5. The implementation uses Win32 list views, edit controls, buttons and the Windows clipboard API. The previous Tao/Wry stack, embedded HTML/JavaScript and frontend test runner have been removed (110 dependency packages removed). Thedesktopfeature only enables additional bindings in the existingwindows-syspackage.Build with
cargo build --features desktop --locked, then runreason-network desktopor double-click that build. The window shows team/machine connectivity, session addresses, projects/branches, activity, delivery tier and local unread counts. It supports Unicode search, Working/Unread filters, refresh, selected-address copying, and explicit team-link copying. Native controls provide keyboard navigation and DPI-aware layout. A failed daemon connection is shown as offline or stale, and polling reconnects automatically.The view reuses
Link::existing()and boundedWho/Linkrequests. It does not start the daemon, register an agent, consume messages or modify configuration. Updates and commands use bounded channels; closing the window aborts polling and leaves the daemon running. Display labels are bounded and sanitized; copied addresses must exactly match the directory and contain no NUL. Clipboard text is transferred as UTF-16 through the native API without launching a subprocess.Validation
On Windows, based on upstream
main@fea09c5:cargo fmt --checkcargo clippy --all-targets --locked -- -D warningscargo clippy --all-targets --features desktop --locked -- -D warningscargo test --lockedandcargo test --features desktop --locked: 251 tests passed in each configurationcargo build --features desktop --lockedgit diff origin/main -- Cargo.lockis empty. Windows CI checks/tests the feature; all three platforms check the default build.This remains a draft for maintainer scope/UX review. Windows-only; no installer, autostart, message composer or approval UI. Real multi-machine UI and long-duration resource tests have not been run. The new commit's CI status is in Checks; no pending run is counted as passed.