Repository navigation
fix(shard): drop fingerprint-only shims and keep WebRTC from failing bot checks - #115
Merged
Merged
Conversation
…ngerprint-only shims The viewer emulator attached to every page from pod start, and the extension replaced geometry, API-surface and media-query APIs in script. Pages can detect both. On the ShardX image the emulator now waits for the first viewer (MVD_EMULATOR_ON_VIEWER=1) and the fingerprint-only shims stay off (MVD_FINGERPRINT_SHIMS=0), since the engine reports those values natively. The select picker, fullscreen, same-tab link and passkey shims are unchanged, and the main image keeps its current behaviour.
Reclaim PR Agent review · run 122739189163
Full findings and Ponytail review
Ponytail suggestions:
net: -3 lines possible. |
…into fix/shard-detection-hotfix
Reclaim PR Agent review · run 122862822479
Full findings and Ponytail review
Ponytail suggestions:
net: -5 lines possible. |
Reclaim PR Agent review · run 123023847435
Full findings and Ponytail review
Ponytail suggestions:
net: -3 lines possible. |
…iewer wait With BROWSER_PUBLIC_IP set to the proxy exit, WebRTC uses TCP only and reports that exit as its public address. Without it, Chrome's disable_non_proxied_udp policy applies, since some bot checks fail when no public candidate appears at all. The emulator attaches at startup again: with the fingerprint shims off, waiting for the first viewer made no difference.
Contributor
Author
|
On the merge gate findings:
The |
Reclaim PR Agent review · run 123404055118
Full findings and Ponytail review
Ponytail suggestions:
net: -6 lines possible. |
Reclaim PR Agent review · run 123422830646
Full findings and Ponytail review
Ponytail: Lean already. Ship. |
Sajjad21990
approved these changes
Oct 29, 2026
predatorx7
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On the ShardX image, pages could detect the viewer tooling or fail bot checks:
BROWSER_PUBLIC_IPset to the proxy exit, WebRTC uses TCP only and reports that exit. Without it, Chrome'sdisable_non_proxied_udppolicy applies. The engine'sblockpolicy failed some bot checks, which expect a public candidate.Testing
go vet,go test.