Repository navigation
feat(chart): optionally sync a Grass proxy template into the proxy secret - #116
Merged
Merged
Conversation
…cret Add secrets.browserRuntimeGrassProxyRemoteKey. When set, the browser-runtime proxy ExternalSecret also maps that Secret Manager key to HTTPS_PROXY_URL_GRASS, which reclaim-api uses for proxyProvider=grass proof requests. The value is empty by default, so existing deployments render and sync exactly as before. Signed-off-by: kryptocodes <srivatsantb@gmail.com>
![reclaim-pr-agent[bot]](https://avatars.githubusercontent.com/in/4862671?s=60&v=4){kind=small}
Reclaim PR Agent review · run 122780098094
Reviewed all 1 diff chunks. No blocking defects found. Ponytail: Lean already. Ship. |
Scratch-net
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
secrets.browserRuntimeGrassProxyRemoteKeyto the browser-fleet chart (default empty).HTTPS_PROXY_URL_GRASS, used by reclaim-api forproxyProvider: "grass"proofs.Compatibility
Default render is unchanged, so existing ExternalSecrets keep syncing even where the Grass secret does not exist.
Testing
helm templatewith the value unset (unchanged output) and set (extraHTTPS_PROXY_URL_GRASSentry).