Skip to content

Add console patterns for the Builder UI - #2

Merged
predatorx7 merged 2 commits into
mainfrom
builder-console-ui
Oct 17, 2026
Merged

predatorx7 merged 2 commits into
mainfrom
builder-console-ui

Conversation

@predatorx7

Copy link
Copy Markdown
Collaborator
  • Add the period picker element, toast behavior, and console and site pattern specs, with catalog sections for each.
  • Fix clicks on icons inside controls: the event target is the SVG, so map it to its parent element. This fixes the theme toggle in dark mode.
  • Show theme icons in light mode, and extend tokens, icons, and the wordmark for the console.

Builder (reclaimprotocol/builder#49) currently pins this commit (2dcfd08) as a git dependency; once merged, it can move to a release.

🤖 Generated with Claude Code

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


daddy seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

daddy and others added 2 commits October 16, 2026 21:36
- Add the period picker element, toast behavior, and console and site
  pattern specs, with catalog sections for each.
- Fix clicks on icons inside controls: the event target is the SVG, so
  map it to its parent element. This fixes the theme toggle in dark mode.
- Show theme icons in light mode, and extend tokens, icons, and the
  wordmark for the console.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@reclaim-pr-agent

Copy link
Copy Markdown

Reclaim PR Agent review · run 117068618545

Result Head Blocking findings Ponytail suggestions Check
Superseded by a new commit 2dcfd08ab110 0 0 View run

The pull-request head changed while AI review was running.

@reclaim-pr-agent

Copy link
Copy Markdown

Reclaim PR Agent review · run 117069731760

Result Head Blocking findings Ponytail suggestions Check
Human review required (incomplete diff) 1a4ed2fc5049 1 12 View run

Human review required:

  • src/css/components.css: GitHub provided no text patch (binary or unavailable).
# Finding
1 .github/workflows/verify.yml: The PR removes the Swift, Flutter, and Android jobs entirely, so PRs and pushes to main no longer run any tests for the repository's native SDKs.…

Human review required for unreviewed changes. Reviewed all 7 diff chunks. Changes required: .github/workflows/verify.yml: The PR removes the Swift, Flutter, and Android jobs entirely, so PRs and pushes to main no longer run any tests for the repository's native SDKs. This silently eliminates regression detection for three supported platform implementations. Smallest safe fix: restore the swift, flutter, and android jobs (including their setup and test commands), or replace them with equiva

# Ponytail suggestion
1 apps/catalog/src/catalog.css:L150: delete: z-index: auto explicitly restates the initial value. Nothing replaces it.
2 src/behaviors/index.ts:L438-627: yagni: Remote combobox/value-input mode, server-result exceptions, and its separate keyboard flow have no changed consumer or spec. Keep the…
3 apps/catalog/src/site-patterns.tsx:L450: delete: Explicit placement: 'bottom-right' repeats showToast’s default. Nothing replaces it.
4 src/tokens/css/tokens.css:L257-268,L561-572: delete: theme-local copies of invariant chart tokens. Inherit the :root declarations.
5 src/tokens/css/tokens.css:L280-281,L584-585: delete: theme-local copies of invariant blue palette tokens. Inherit the :root declarations.
6 src/tokens/css/tokens.css:L301-303,L608-610: delete: theme-local copies of invariant pastel palette tokens. Inherit the :root declarations.
7 src/tokens/css/tokens.css:L340-342,L647-649: delete: theme-local copies of invariant dialog-size tokens. Inherit the :root declarations.
8 src/tokens/css/tokens.css:L391-423,L698-730: delete: theme-local copies of invariant added typography tokens. Inherit the :root declarations.
9 src/tokens/css/tokens.css:L449-479,L756-786: delete: theme-local copies of invariant icon, image, and layout tokens. Inherit the :root declarations.
10 src/tokens/css/tokens.css:L492-495,L799-802: delete: theme-local copies of invariant opacity and progress-ring tokens. Inherit the :root declarations.

2 more suggestions in the details below.

Full findings and Ponytail review
  • .github/workflows/verify.yml: The PR removes the Swift, Flutter, and Android jobs entirely, so PRs and pushes to main no longer run any tests for the repository's native SDKs. This silently eliminates regression detection for three supported platform implementations. Smallest safe fix: restore the swift, flutter, and android jobs (including their setup and test commands), or replace them with equivalent native test coverage in the required workflow.

Ponytail suggestions:

  • apps/catalog/src/catalog.css:L150: delete: z-index: auto explicitly restates the initial value. Nothing replaces it.
  • src/behaviors/index.ts:L438-627: yagni: Remote combobox/value-input mode, server-result exceptions, and its separate keyboard flow have no changed consumer or spec. Keep the existing local filtering/selection controller.
  • apps/catalog/src/site-patterns.tsx:L450: delete: Explicit placement: 'bottom-right' repeats showToast’s default. Nothing replaces it.
  • src/tokens/css/tokens.css:L257-268,L561-572: delete: theme-local copies of invariant chart tokens. Inherit the :root declarations.
  • src/tokens/css/tokens.css:L280-281,L584-585: delete: theme-local copies of invariant blue palette tokens. Inherit the :root declarations.
  • src/tokens/css/tokens.css:L301-303,L608-610: delete: theme-local copies of invariant pastel palette tokens. Inherit the :root declarations.
  • src/tokens/css/tokens.css:L340-342,L647-649: delete: theme-local copies of invariant dialog-size tokens. Inherit the :root declarations.
  • src/tokens/css/tokens.css:L391-423,L698-730: delete: theme-local copies of invariant added typography tokens. Inherit the :root declarations.
  • src/tokens/css/tokens.css:L449-479,L756-786: delete: theme-local copies of invariant icon, image, and layout tokens. Inherit the :root declarations.
  • src/tokens/css/tokens.css:L492-495,L799-802: delete: theme-local copies of invariant opacity and progress-ring tokens. Inherit the :root declarations.
  • src/tokens/css/tokens.css:L502-538,L809-845: delete: theme-local copies of invariant added size and spacing tokens. Inherit the :root declarations.
  • src/tokens/types/tokens.ts:L253,L559: shrink: light and dark repeat the newly added theme-invariant core-token entries. Start each theme with ...coreTokens and retain only its overrides.

net: -498 lines possible.

@predatorx7
predatorx7 merged commit 86e69ff into main Oct 17, 2026
4 checks passed
@predatorx7
predatorx7 deleted the builder-console-ui branch October 17, 2026 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants