Skip to content

Link the catalog to its GitHub source - #3

Merged
predatorx7 merged 1 commit into
mainfrom
catalog-github-link
Oct 17, 2026
Merged

predatorx7 merged 1 commit into
mainfrom
catalog-github-link

Conversation

@predatorx7

Copy link
Copy Markdown
Collaborator

Summary

  • Adds a Source on GitHub link with the GitHub mark to the bottom of the catalog sidebar (replaces the "Deterministic fixtures" label; v0.1 stays).
  • Adds the same link to the bottom of the mobile menu sheet (≤900px), since the sidebar is hidden there.
  • The link opens https://github.com/reclaimprotocol/reclaim-design in a new tab, keeps a 44px touch target, and uses the 2px focus-ring outline.
  • The GitHub mark is an inline SVG local to the catalog, not part of the published icon set.

Testing

  • npm run verify:full: passes (42/42 e2e across desktop, tablet, and phone).
  • Extended the responsive shell e2e test to assert the link href in the sidebar (desktop) and in the menu sheet (tablet/phone).

🤖 Generated with Claude Code

Add a GitHub-marked source link to the sidebar footer and the mobile
menu sheet, with e2e coverage on both layouts.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@reclaim-pr-agent reclaim-pr-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by Reclaim PR Agent after an automated GPT-5.6 Terra review.

@reclaim-pr-agent

Copy link
Copy Markdown

Reclaim PR Agent review · run 117335534713

Result Head Blocking findings Ponytail suggestions Check
Approved 70047651e624 0 2 View run

Reviewed all 1 diff chunks. No blocking defects found.

# Ponytail suggestion
1 apps/catalog/src/catalog.css:L843-844: delete: mobile rule repeats inherited color and gap. Nothing; retain only its border and margin overrides.
2 apps/catalog/src/main.tsx:L247: yagni: one-use sourceRepositoryUrl constant. Inline the URL in href.
Full findings and Ponytail review

Ponytail suggestions:

  • apps/catalog/src/catalog.css:L843-844: delete: mobile rule repeats inherited color and gap. Nothing; retain only its border and margin overrides.
  • apps/catalog/src/main.tsx:L247: yagni: one-use sourceRepositoryUrl constant. Inline the URL in href.

net: -3 lines possible.

@predatorx7
predatorx7 merged commit 60641e2 into main Oct 17, 2026
4 checks passed
@predatorx7
predatorx7 deleted the catalog-github-link branch October 17, 2026 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant