Repository navigation
Conversation
|
Hello, this PR has been open since August 9 and has not yet received a review. I see that #11 has since updated the certificate fixture and certificate-parsing code, which has caused this PR to conflict with main. The remaining substantive change is IP-literal endpoint identity handling. Before I spend time rebasing it, could you please confirm whether this feat is something the project would like to support? |
|
The parser passes !hasCompression to parseIpv6Side(). For an uncompressed address, hasCompression is false, so canContainIpv4 is true, not false. I verified the exact example 1:2:3:4:5:6:192.0.2.10 locally: it is accepted and produces the same 16-byte identity as 1:2:3:4:5:6:c000:20a. The requested behavior is therefore already implemented. Please re-evaluate this finding against the current revision. |
caea5a4 to
eddb00d
Compare
276307d to
380052c
Compare
|
Today is Sep 14, 2026. Did the current date get left out your prompt? |
380052c to
2dae37d
Compare
Description
Fix TLS endpoint identity handling when the configured host is a literal IPv4 or IPv6 address.
This change:
server_nameextension for IP literals.subjectAltName.iPAddressentries.Implementation
Uint8Array, no Node-onlynet.isIP()dependency is introduced.SERVER_NAMEextension when constructing a ClientHello for an IP reference.iPAddressSAN values separately fromdNSNameSAN values.Tests
Added coverage for:
iPAddressSAN matching.dNSNamefields.Also added the browser/JavaScriptCore bundle build to CI.
Type of change
Checklist: