fix(core): use aware UTC timestamps#193
Merged
Merged
Conversation
dextmorgn
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: two core timestamp paths still used
datetime.utcnow(): JWT expiration increate_access_token()and the default 24-hour cutoff inLogRepository.get_by_sketch(). The project already uses timezone-aware UTC timestamps in nearby core services and models.Before / after: before, both paths produced naive UTC datetimes. After, they use
datetime.now(timezone.utc), matching the repo's timezone-aware timestamp style while preserving the same expiry duration and one-day log cutoff behavior.Verification:
python -m py_compile flowsint-core\src\flowsint_core\core\auth.py flowsint-core\src\flowsint_core\core\repositories\log_repository.pypython -m pytest flowsint-core\tests\repositories\test_log_repository.pywith source paths configured, but this local environment is missingpasslib, so the test run stops during import before executing tests.