feat: homepage run rows render the real task title, generic label as fallback#1857
feat: homepage run rows render the real task title, generic label as fallback#1857sweetmantech wants to merge 1 commit into
Conversation
…lback (chat#1850) GET /api/tasks/runs list runs gain a nullable title (the originating scheduled task's title). HomeRunRow renders it via the new pure helper getRunDisplayName, falling back to getTaskDisplayName(taskIdentifier) when title is null/absent — today's behavior, so the row is zero-regression until the api change deploys. Home-domain only; no shared-component changes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Warning Review limit reached
Next review available in: 39 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 4 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Requires human review: Although small and TDD-covered, this change touches the homepage task runs rendering and depends on a separate API deployment, risking subtle rendering regressions; it warrants human review.
Re-trigger cubic
1 participant
What
Homepage run rows (
HomeRunRow) render the originating scheduled task's title fromGET /api/tasks/runs, falling back to the currentgetTaskDisplayName(taskIdentifier)label when no title is resolvable. Closes the video-parity gap where five runs all read "Scheduled Task" (#1850, video-parity item 1, promoted from the chat#1853 fast-follow note).Changes
lib/tasks/getTaskRuns.ts—TaskRunItemgains optionaltitle?: string | null(matches the amended contract in docs(tasks): nullabletitleon task runs — originating scheduled task's title docs#268)lib/tasks/getRunDisplayName.ts(new, pure) — title when present and non-empty, else the per-taskIdentifier labelcomponents/Home/HomeRunRow.tsx— rendersgetRunDisplayName(run)Home domain only:
chat.tsx,NewChatBootstrap,HomePage, and all shared components are untouched (house standard from this issue).Deploy note (zero regression)
Titles render once the api PR (recoupable/api#764) deploys. Until then
titleis absent from the response and every row falls back to today's exact behavior — the fallback path is the current label logic, unit-covered including the absent-field (pre-title api) case.Verification
getRunDisplayNametest written first and confirmed RED (module missing), then GREENtsc --noEmit: 8 errors = exact pre-existing baseline, 0 new (none in touched files)Links
titleon task runs — originating scheduled task's title docs#268 · API: feat(tasks): thread scheduled task titles onto GET /api/tasks/runs list runs api#764🤖 Generated with Claude Code
Summary by cubic
Homepage run rows now show the scheduled task’s title from
GET /api/tasks/runs, falling back to the generic per-task label. This fixes the “five runs all read ‘Scheduled Task’” issue (chat#1850) and improves clarity.TaskRunItemnow includestitle?: string | nullfromGET /api/tasks/runs.getRunDisplayName(run)to choose the title orgetTaskDisplayName(taskIdentifier)as a fallback.HomeRunRowrendersgetRunDisplayName(run)for each row.Written for commit 3bbf481. Summary will update on new commits.