Skip to content

docs(skills): ship-issue skill targets main, not test#68

Merged
sweetmantech merged 4 commits into
mainfrom
chore/dev-skills-pr-against-main
Jul 3, 2026
Merged

docs(skills): ship-issue skill targets main, not test#68
sweetmantech merged 4 commits into
mainfrom
chore/dev-skills-pr-against-main

Conversation

@sweetmantech

@sweetmantech sweetmantech commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

What

Updates the recoup-internal-dev-ship-issue skill so it tells the agent to open api PRs against main, not test.

Why

We're retiring the testmain staging step (it was always an auto-merge) to speed up the release cycle. PRs now go directly against main for api (and chat). Decision recorded in recoupable/chat#1829.

Changed (4 branch-target references)

  • The loop diagram: PR target: testPR target: main
  • Recoup apiPRs targettest → `…target `main
  • open the api PR (base test)…(base main)
  • The promote step: squash → test, then test → main via a release PR…squash-merge directly to main

The TDD / test-suite references (pnpm test, red→green) are untouched — only the branch target changed.

Note (out of scope)

The recoup-internal-dev-issue-tracker skill has one testmain mention, but it's inside a historical example closure note (a real past PR that did go through test) — left as-is to avoid falsifying the example. Say the word if you'd rather genericize it.

🤖 Generated with Claude Code


Summary by cubic

Update recoup-internal-dev-ship-issue so api PRs target main, removing the testmain stage to speed up releases. Tightens the doc/checklist to squash-merge to main and require updating the tracking issue’s PR-matrix row at PR-open time (repo#TBD → live ref + status).

  • Refactors
    • Removed restated “Principles”, vestigial promote/release-scope notes, the redundant Vercel CLI line, and duplicate mentions of the branch-target rule.
    • Corrected generated-JSON guidance: favor anchored text edits when round-tripping fails; keep diffs additive and re-validate.
    • Added a preview-auth note: preview envs may use different auth/secrets; use preview-scoped creds to avoid 401s.

Written for commit c43355f. Summary will update on new commits.

Review in cubic

We're collapsing the `test` → `main` staging step (it was always an
auto-merge) to speed up the release cycle, so api PRs now go directly against
`main`. Updates the recoup-internal-dev-ship-issue skill's branch-target
guidance (PR base, the loop diagram, and the promote step). The test *suite*
references (TDD / `pnpm test`) are unchanged — only the branch target.

Ref: recoupable/chat#1829

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@sweetmantech, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 20 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5043b447-d21b-4a3c-a8fa-355e4a1fd833

📥 Commits

Reviewing files that changed from the base of the PR and between 435a335 and c43355f.

📒 Files selected for processing (1)
  • skills/recoup-internal-dev-ship-issue/SKILL.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/dev-skills-pr-against-main

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

Replace the repo#TBD placeholder with the live ref + verification
status in the same session each PR opens (not batched, not at merge).
Gap caught on recoupable/chat#1841.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
sweetmantech and others added 2 commits July 3, 2026 15:22
…ssons

Deleted the Principles section (pure restatement of the loop and
checklist), the vestigial release-scope/promote-flow language, the
redundant vercel-CLI line, and the triple-stated main-target rule.
Corrected the generated-JSON guidance (round-trip often fails; anchored
insertion is the real path) and added the preview-auth lesson (preview
envs can run different Privy/secret config; prod credentials 401).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@sweetmantech sweetmantech merged commit 70404b8 into main Jul 3, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant