docs(skills): task-email-audit — round-2 learnings (conditional no-sends, 401-rejected rows, retry resets)#73
Merged
Conversation
…eds no feedback Three findings from the 2026-07-02 benchmark rounds that would misclassify tomorrow's results: - Conditional task prompts (roster-wide new-video sweep) make no-send a SUCCESS; classify runs sent / correct-no-send / failed by reading the run's conclusion. - rejected rows can be expired-ephemeral-key 401s (burst of ~35 from one long run), not guard blocks — distinguish via the trace before reporting guard stats. - Workflow-step retries reset the persisted assistant message (part counts shrink); don't read that as data loss. Plus: vercel-login-expired fallback note on the prod-key step. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
📝 WalkthroughWalkthroughThis PR updates the "Caveats" section of the recoup-internal-task-email-audit SKILL.md documentation with expanded guidance on interpreting audit data: conditional no-send outcomes, rejected email log causes, chat_messages part-count fluctuations, and vercel login token error handling. ChangesSKILL.md Caveats Update
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…nings, pre-fix era removed) Per review: additions should be paid for with removals. The round-2 learnings (conditional no-sends are successes; rejected can be 401 key-expiry; retry resets part counts; vercel-login fallback) are now folded into tightened caveats, funded by cutting what the shipped fixes made obsolete: the blocked-empties listing section (§1 headline already counts them), the helper-adoption section (helper shipped + registered), the dated 07-01 reference-point anecdote, the pre-fix Resend-scraping fallback method, and baseline percentages (linked issues carry the history). Sections renumbered (old §6/§7 → §4/§5), all refs updated. Net vs main: +25/−51. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prep so tomorrow's post-deploy audit runs without operator feedback — net-negative diff (+25/−51): the new learnings are funded by removing what the shipped fixes made obsolete.
Added (as tightened caveats)
sent/correct no-send/failed— conditional prompts (e.g. the rewritten roster-wide new-video sweep) make no-send a success; read the run's final narration before judging.rejected≠ always guard-blocked — expired ephemeral keys (runs >~20 min) log 401 retries asrejectedin bursts; triage via the trace before reporting guard stats.TRIGGER_SECRET_KEYstep.Removed (obsolete after chat#1829 + chat#1833 shipped)
CI green:
check_resolvable,run_resolver_eval(structural),validate_manifests.🤖 Generated with Claude Code