Repository navigation
ci: backport remaining rhoai-3.3 compatibility fixes - #697
Closed
NeriCarcasci wants to merge 12 commits into
Closed
NeriCarcasci wants to merge 12 commits into
NeriCarcasci wants to merge 12 commits into
Conversation
CI on rhoai-3.3 started failing after unpinned tools drifted: openai 3 dropped httpx, opentelemetry-sdk 1.43 added processor _metrics, and Alembic 1.19 compares named CHECK constraints. Pin the drifting deps and match the 3.5 schema/processor one-liners so unrelated CVE PRs can merge. Co-authored-by: Cursor <cursoragent@cursor.com>
The pyfunc lock tests resolved unconstrained openai from PyPI (3.x uses httpx2, not httpx). The otel error-logging test asserted a logger call shape that no longer fires. Accept httpx or httpx2, and assert stored traces instead of exporter internals. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep the openai==1.82.0 lock test asserting httpx, and restore an ERROR-level caplog check so a failed span export cannot be silently swallowed. Co-authored-by: Cursor <cursoragent@cursor.com>
Backport of upstream MLflow mlflow#23108 for the rhoai-3.3 CI dependency set.
There was a problem hiding this comment.
🟡 Changes recommended
Several material dependency, runtime, and model-behavior changes are absent from the stated scope and validation details.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 12/12 changed files
- Comments generated: 3
- Review effort level: Balanced
rhoai-3.3 CI…hoai-3.3 # Conflicts: # mlflow/store/tracking/dbmodels/models.py # tests/pyfunc/test_model_export_with_class_and_artifacts.py # tests/tracing/test_otel_logging.py
Use pinned MinIO images from Quay for the artifact example and backport the upstream auth-server readiness polling fix. Signed-off-by: Neri Carcasci <nericarcasci@gmail.com>
NeriCarcasci
force-pushed
the
chore/ci-unblock-rhoai-3.3
branch
from
September 15, 2026 13:57
e342e2d to
284ad5a
Compare
Author
|
Closing in favor of #737 after re-auditing the current #737 contains only the three remaining example-dependency compatibility backports, with upstream contributors recorded as co-authors and DCO sign-offs. The artifact-image replacement is intentionally excluded because #735 already owns that work. Both PRs are intended to unblock #656 and #677 without carrying the exploratory history or unrelated changes from this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Unblock the
rhoai-3.3CVE updates in #656 and #677 by fixing the remaining base-branch CI and dependency-compatibility failures that are unrelated to either CVE diff.Although this PR's commit history contains earlier investigation and merge-resolution work, the final review scope is seven files. The table below is the authoritative description of every surviving change.
Baseline evidence
The failures are reproducible without either CVE change:
rhoai-3.3head with zero changed files. Itspython (2)job failed only becausetests/tracking/test_mlflow_artifacts.py::test_mlflow_artifacts_examplecould not pullminio/miniofrom Docker Hub. The result was recorded and the temporary PR was closed.mlflow_artifactsexample #735 independently encountered the same artifact-example failure. Replacing MinIO with RustFS made itspython (2)job pass, confirming that the failure is in the shared example infrastructure rather than the CVE changes.Final changes and reasons
mlflow/R/mlflow/Dockerfile.devrocker/r-verfrom 4.2.1 to 4.4.2 and installlibcurl4-openssl-devandlibuv1.fspackage requires thelibuv.so.1runtime. This affects the development/docs image only, not the shipped MLflow runtime image..github/workflows/examples.ymlPIP_CONSTRAINT..github/workflows/examples.ymlDockerfileand.dockerignore, and print the actual matched files.requirements/extra-ml-requirements.txttensorboardwithout a duplicate version bound.TBNotInstalledError. TensorFlow's metadata selects the compatible TensorBoard version.mlflow/sentence_transformers/__init__.pyencode, including an empty-input guard.tests/tracking/test_mlflow_artifacts.pytests/server/auth/test_auth.pypython (3).examples/mlflow_artifacts/docker-compose.ymlpull access denied. Pinned Quay tags keep the existing MinIO-based example and make the test reproducible. The zero-diff #736 result demonstrates that this failure exists on the base branch.Scope and provenance
PIP_CONSTRAINTrestoration is explicitly attributed to mlflow/mlflow#20396 here.Testing
At current head
284ad5a8b, the complete reported GitHub Actions matrix passes, including:Additional targeted validation:
git diff --checkis cleanFor comparison, the zero-diff baseline #736 failed
python (2)at the Docker Hub pull, while #697 passes that job with the two pinned Quay references.Documentation
Release notes