Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PICache currently releases Mamba slots one at a time. Every released slot constructs a separate tensor and calls the allocator independently, producing repeated device work and repeated
torch.catoperations.Modifications
Accuracy Tests
Not applicable. The change preserves allocator state and cache contents while batching the release operation.
Speed Tests and Profiling
A focused CPU allocator benchmark was run seven times for each batch size:
These measurements isolate state-allocator bookkeeping; they are not end-to-end inference timings.
Test Plan
The focused tests passed locally and on a clean DigitalOcean Linux environment at commit
98b7618a06a0aa1089324d49a78d4bc4674d1642.Coverage verifies:
Closes #5.