Skip to content

fix(sft): load_video call sites omit the required use_audio_in_video and keep the raw 4-tuple #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Anai-Guo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(sft): load_video call sites omit the required use_audio_in_video and keep the raw 4-tuple #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion relax/engine/sft/dataset/multimodal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def _fetch_media(sample: CanonicalSample, rendered_text: str) -> tuple[dict[str,
if sample.images:
mm_inputs["images"] = [load_image(p) for p in sample.images]
if sample.videos:
mm_inputs["videos"] = [load_video(p) for p in sample.videos]
mm_inputs["videos"] = [load_video(p, use_audio_in_video=False)[0] for p in sample.videos]
if sample.audios:
mm_inputs["audios"] = [load_audio(p) for p in sample.audios]
return mm_inputs, rendered_text
Expand Down
2 changes: 1 addition & 1 deletion relax/engine/sft/predict/loop.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def _build_multimodal_inputs(sample: CanonicalSample) -> dict | None:

return {
"images": [load_image(p) for p in (sample.images or [])],
"videos": [load_video(p) for p in (sample.videos or [])],
"videos": [load_video(p, use_audio_in_video=False)[0] for p in (sample.videos or [])],
"audio": [load_audio(p) for p in (sample.audios or [])],
}

Expand Down
Loading