feat: prep for Linux, Windows, and Android support#1
Open
cbaker6 wants to merge 13 commits intoreddavis:mainfrom
Open
feat: prep for Linux, Windows, and Android support#1cbaker6 wants to merge 13 commits intoreddavis:mainfrom
cbaker6 wants to merge 13 commits intoreddavis:mainfrom
Conversation
reddavis
reviewed
Feb 20, 2022
| do { | ||
| try self.createDirectoryIfNeeded(at: self.url) | ||
| } catch { | ||
| #if !os(Linux) && !os(Android) && !os(Windows) |
Owner
There was a problem hiding this comment.
I wonder whether it is cleaner to bring these checks inside the Logger class. So the Logger class decides whether to print or use os log?
Contributor
Author
There was a problem hiding this comment.
If I remember correctly, Linux, Android, and Windows don't have os.log, so it can't go directly in the logger. I'm not sure if those OS's have an equivalent logger
Conflicts: Papyrus/Source/PapyrusStore.swift
Contributor
Author
|
Not sure what's wrong with the SPM build as it builds locally, but I can't get it working in the CI, so I commented it out. As for Linux and Windows, you can see code needs to be updated to get build/test working here. I commented out Linux and Windows in the CI just incase you want to build test in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @reddavis, just saw your framework earlier today on Swift Package Index and I think it's promising, great work!
I think this can be very useful for those who use ParseSwift.
Please have a look at this PR for preparing the project for adding Linux, Windows, and Android support. There are some methods used related to
DispatchSourcethat won't allow for building on Linux, Windows, and Android. In the future if these become supported or if there are other methods used, this framework can work on those OS's.Let me know what you think...
Updates in this PR:
CombineandLoggerfunctionality on Apple Platforms.Package.swift, the tests pass locally for these. You might want to add builds for these in a future PRPackage.swift