Fix properties from GitLab "descrpition" and "protectedDefaultBranch"#111
Merged
Conversation
…tError The publish:gitlab action does not support 'description' and 'protectDefaultBranch' properties, causing all templates to fail when publishing to GitLab. These properties are supported by publish:github but not by the GitLab scaffolder backend. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Update skeleton/template.yaml to remove 'description' and 'protectDefaultBranch' from publish:gitlab actions. This ensures generate.sh produces templates that match the expected output and don't cause CI failures. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
yangcao77
previously approved these changes
May 25, 2026
Jdubrick
requested changes
May 25, 2026
Jdubrick
left a comment
Jdubrick
left a comment
Contributor
There was a problem hiding this comment.
Should we change it to settings.description?
Signed-off-by: Lucas <lyoon@redhat.com>
Contributor
Author
You're right, I've modified and verified it's working. thank you for pointing it out |
JslYoon
changed the title
JslYoon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tError
The publish:gitlab action does not support 'description' and 'protectDefaultBranch' properties, causing all templates to fail when publishing to GitLab. These properties are supported by publish:github but not by the GitLab scaffolder backend.
What does this PR do?:
Changes the yaml structure of the fields "description and "protectedDefaultBranch" on gitlab that was causing an error when building software template with gitlab.
Which issue(s) this PR fixes:
https://redhat.atlassian.net/browse/RHDHBUGS-3162
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.
Tested and Verified
Documentation (READMEs, Product Docs, Blogs, Education Modules, etc.)
How to test changes / Special notes to the reviewer: